Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds snapshot test coverage for handling colons in filenames. The test verifies that the task runner correctly processes commands that reference files with colons in their names (e.g., Node.js built-in module specifiers like "node:fs") and properly caches and replays such tasks.
Key changes:
- Added a new snapshot test case
colon-in-namethat exercises the task runner with a filename containing a colon - The test runs the same task twice to verify both cache miss and cache hit scenarios work correctly with colon-containing filenames
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/cli/snap-tests/colon-in-name/steps.json | Defines test execution steps with commands to run the test task twice |
| packages/cli/snap-tests/colon-in-name/snap.txt | Contains expected output showing successful execution and caching of tasks with colon-containing filenames |
| packages/cli/snap-tests/colon-in-name/package.json | Defines the test script that attempts to read a file with a colon in its name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
branchseer
force-pushed
the
11-19-fix_task_allow_colons_in_filenames
branch
from
cbb4ade to
2eb3464
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
branchseer
force-pushed
the
11-19-fix_task_allow_colons_in_filenames
branch
from
c659143 to
27b0805
Compare
Merge activity
|
No description provided.